[REF] Remove always false if #20653
Merged
[REF] Remove always false if #20653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added code to ensure line_item is always populated before this function is called. So line items is never empty at this point
|
(Standard links)
|
| @@ -3415,11 +3419,6 @@ public static function recordFinancialAccounts(&$params, $financialTrxnValues = | |||
|
|
|||
| $statusId = $params['contribution']->contribution_status_id; | |||
|
|
|||
| // build line item array if its not set in $params | |||
| if (empty($params['line_item']) || $additionalParticipantId) { | |||
| CRM_Price_BAO_LineItem::getLineItemArray($params, $entityID, str_replace('civicrm_', '', $entityTable), $isRelatedId); | |||
There was a problem hiding this comment.
isRelatedId also removed as that is only set for memberships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Remove always false if
Before
recordFinancialAccounts checks is line items is empty - but it never is due to these lines
After
The check for empty is removed, the code is moved into the if that would make it possibly true.
Technical Details
We recently added code to ensure line_item is always populated
before this function is called
civicrm-core/CRM/Contribute/BAO/Contribution.php
Lines 174 to 177 in efac3dc
(it is only called from one place in core which is a few lines further down)
So line items is never empty at this point
Comments
There is more cleanup that can follow on from this - ie removing more unused stuff - but I wanted to keep this easy to review